openstack/swift
Code Issues Proposed changes

Merge "Fix missing Accept-Ranges"

Browse Source
This commit is contained in:
Jenkins
2016-02-08 12:33:25 +00:00
committed by Gerrit Code Review
parent 98589640ce b173995666
commit 76c38670c2
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
swift/proxy/controllers/obj.py
View File

@@ -2057,6 +2057,7 @@ class ECObjectController(BaseObjectController):
headers=resp_headers, headers=resp_headers,
conditional_response=True, conditional_response=True,
app_iter=app_iter) app_iter=app_iter)
resp.accept_ranges = 'bytes'
app_iter.kickoff(req, resp) app_iter.kickoff(req, resp)
else: else:
statuses = [] statuses = []

3
test/unit/proxy/controllers/test_obj.py
View File

@@ -390,6 +390,7 @@ class BaseObjectControllerMixin(object):
with set_http_connect(200): with set_http_connect(200):
resp = req.get_response(self.app) resp = req.get_response(self.app)
self.assertEqual(resp.status_int, 200) self.assertEqual(resp.status_int, 200)
self.assertIn('Accept-Ranges', resp.headers)
def test_HEAD_x_newest(self): def test_HEAD_x_newest(self):
req = swift.common.swob.Request.blank('/v1/a/c/o', method='HEAD', req = swift.common.swob.Request.blank('/v1/a/c/o', method='HEAD',
@@ -693,6 +694,7 @@ class TestReplicatedObjController(BaseObjectControllerMixin,
with set_http_connect(200): with set_http_connect(200):
resp = req.get_response(self.app) resp = req.get_response(self.app)
self.assertEqual(resp.status_int, 200) self.assertEqual(resp.status_int, 200)
self.assertIn('Accept-Ranges', resp.headers)
def test_GET_error(self): def test_GET_error(self):
req = swift.common.swob.Request.blank('/v1/a/c/o') req = swift.common.swob.Request.blank('/v1/a/c/o')
@@ -1173,6 +1175,7 @@ class TestECObjController(BaseObjectControllerMixin, unittest.TestCase):
with set_http_connect(*get_resp): with set_http_connect(*get_resp):
resp = req.get_response(self.app) resp = req.get_response(self.app)
self.assertEqual(resp.status_int, 200) self.assertEqual(resp.status_int, 200)
self.assertIn('Accept-Ranges', resp.headers)
def test_GET_simple_x_newest(self): def test_GET_simple_x_newest(self):
req = swift.common.swob.Request.blank('/v1/a/c/o', req = swift.common.swob.Request.blank('/v1/a/c/o',