openstack/swift
Code Issues Proposed changes

Fixups for ghost listing fix

Browse Source 
I think the probetest can be a little more pathological and I'm worried
about logging the response of each individual request at error when we
currently only log the entire failure at debug.

I have lots of async pendings sometimes.

Related-Change: Ic5d55ff368cec62ab2eb9fd883801ba4ab043dd4
Change-Id: I1c070b2b07d31552f36b647731b0b3ebed31871f
This commit is contained in:
Clay Gerrard
2016-12-01 07:30:40 -08:00
parent ede42c77f1
commit 765cc945d6
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
swift/obj/updater.py
View File

@@ -270,7 +270,7 @@ class ObjectUpdater(Daemon):
resp.read() resp.read()
success = is_success(resp.status) success = is_success(resp.status)
if not success: if not success:
self.logger.error( self.logger.debug(
_('Error code %(status)d is returned from remote ' _('Error code %(status)d is returned from remote '
'server %(ip)s: %(port)s / %(device)s'), 'server %(ip)s: %(port)s / %(device)s'),
{'status': resp.status, 'ip': node['ip'], {'status': resp.status, 'ip': node['ip'],

3
test/probe/test_object_async_update.py
View File

@@ -109,6 +109,9 @@ class TestObjectAsyncUpdate(ReplProbeTest):
self.assertFalse(direct_client.direct_get_container( self.assertFalse(direct_client.direct_get_container(
cnode, cpart, self.account, container)[1]) cnode, cpart, self.account, container)[1])
# since the container is empty - we can delete it!
client.delete_container(self.url, self.token, container)
# Re-run the object-updaters and now container replicas in primary # Re-run the object-updaters and now container replicas in primary
# container servers should get updated # container servers should get updated
Manager(['object-updater']).once() Manager(['object-updater']).once()