openstack/swift
Code Issues Proposed changes

Document the unnecessary method invoking in FakeRing

Browse Source 
Add comment to explain why we invoke the get_part method even if the
_part_shift is equal to 32.

Closes-Bug:  #1335581

Change-Id: I160e9383b5e65f75ed5e89511cc7e63c51958a25
This commit is contained in:
YummyBian
2014-06-29 22:03:33 +08:00
committed by Christian Schwede
parent c94779d2ac
commit 2f45600c7d
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/unit/__init__.py
View File

@@ -140,6 +140,7 @@ class FakeRing(Ring):
self._reload() self._reload()
def get_part(self, *args, **kwargs): def get_part(self, *args, **kwargs):
# always call the real method, even if the fake ignores the result
real_part = super(FakeRing, self).get_part(*args, **kwargs) real_part = super(FakeRing, self).get_part(*args, **kwargs)
if self._part_shift == 32: if self._part_shift == 32:
return 1 return 1