From 9210444245cccf7ac02c708a77c2d3e34631f04c Mon Sep 17 00:00:00 2001 From: Thierry Carrez Date: Wed, 28 Mar 2018 15:04:13 +0200 Subject: [PATCH] Catch errors in release processing script The releases playbook calls process_release_requests.sh, which calls process_release_requests.py, which calls release.sh and make_branch.sh as necessary. If an error happens during release.sh or make_branch.sh, the error is propagated back to process_release_requests.py, but that script failed to propagate the error back to process_release_requests.sh. This could result in the job appearing to complete successfully, while it actually failed to do anything (whatever the reason is). Change-Id: I10e5362e4d14cb9d787cf09f62d0b67f7dce8a03 --- .../files/release-tools/process_release_requests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/copy-release-tools-scripts/files/release-tools/process_release_requests.py b/roles/copy-release-tools-scripts/files/release-tools/process_release_requests.py index e2e139a7cd..2d6ebbf40d 100755 --- a/roles/copy-release-tools-scripts/files/release-tools/process_release_requests.py +++ b/roles/copy-release-tools-scripts/files/release-tools/process_release_requests.py @@ -234,4 +234,4 @@ def main(): if __name__ == '__main__': - main() + sys.exit(main())