From 53d254bc73e95a72cdc5cec89d34c8c3939639ed Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Sat, 5 Jul 2025 14:27:07 +0000 Subject: [PATCH] Remove superfluous quoting on commit trailer The nested quoting in playbooks/proposal/propose_update.sh is ends up causing the shell to escape the inner quotes changing the way git commit interprets the --trailer value. Since the string doesn't contain any embedded whitespace, we can just drop those quotes. Change-Id: I70adf049b01917d79839d3b4dd52248acc6d0494 --- playbooks/proposal/propose_update.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/proposal/propose_update.sh b/playbooks/proposal/propose_update.sh index 288f1e74b0..7660f9c009 100755 --- a/playbooks/proposal/propose_update.sh +++ b/playbooks/proposal/propose_update.sh @@ -176,7 +176,7 @@ for PROJECT in $PROJECTS; do pushd $PROJECT_DIR if ! git diff --stat --exit-code HEAD ; then # Commit and review - git_args="-a -F- -s --trailer='Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh'" + git_args="-a -F- -s --trailer=Generated-By:openstack/project-config:playbooks/proposal/propose_update.sh" git commit $git_args <