From 2a4997044cafd89d2e89b3e8fda222cb1d59f63c Mon Sep 17 00:00:00 2001 From: confi-surya Date: Fri, 21 Dec 2018 11:50:56 +0530 Subject: [PATCH] Add 'Review-Priority' for Kolla repos Following the work done for Designate with Id7b4c6b219899fa7ed86554257264af7efe20408, this adds a Review-Priority label for Kolla projects to allow easier priority dashboard creation and a cleaner way to do procedural blocking during freezes. Change-Id: I03b71534173899b2c22987f199d1753472842a12 --- gerrit/acls/openstack/kolla-ansible.config | 13 +++++++++++++ gerrit/acls/openstack/kolla-cli.config | 13 +++++++++++++ gerrit/acls/openstack/kolla.config | 13 +++++++++++++ 3 files changed, 39 insertions(+) diff --git a/gerrit/acls/openstack/kolla-ansible.config b/gerrit/acls/openstack/kolla-ansible.config index acbeaf6e5e..c018542e1d 100644 --- a/gerrit/acls/openstack/kolla-ansible.config +++ b/gerrit/acls/openstack/kolla-ansible.config @@ -1,8 +1,21 @@ [access "refs/heads/*"] abandon = group kolla-ansible-core label-Code-Review = -2..+2 group kolla-ansible-core +label-Review-Priority = -1..+2 group kolla-ansible-core label-Workflow = -1..+1 group kolla-ansible-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/kolla-cli.config b/gerrit/acls/openstack/kolla-cli.config index 3932a8952f..887b9284b8 100644 --- a/gerrit/acls/openstack/kolla-cli.config +++ b/gerrit/acls/openstack/kolla-cli.config @@ -1,8 +1,21 @@ [access "refs/heads/*"] abandon = group kolla-cli-core label-Code-Review = -2..+2 group kolla-cli-core +label-Review-Priority = -1..+2 group kolla-cli-core label-Workflow = -1..+1 group kolla-cli-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/kolla.config b/gerrit/acls/openstack/kolla.config index a6e8b0d890..2be5464205 100644 --- a/gerrit/acls/openstack/kolla.config +++ b/gerrit/acls/openstack/kolla.config @@ -1,8 +1,21 @@ [access "refs/heads/*"] abandon = group kolla-core label-Code-Review = -2..+2 group kolla-core +label-Review-Priority = -1..+2 group kolla-core label-Workflow = -1..+1 group kolla-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true